refactor: Updated Foundry Roles name#436
Open
AjitPadhi-Microsoft wants to merge 1 commit into
Open
Conversation
AjitPadhi-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
AjitPadhi-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
AjitPadhi-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the solution’s AI service role assignment references to use the “Foundry User” naming (replacing “Azure AI User”) and refreshes the generated ARM template output (infra/main.json) based on a newer Bicep compiler.
Changes:
- Updated Bicep inline comments and local setup documentation to reference Foundry User.
- Regenerated
infra/main.jsonwith Bicep 0.43.8.12551, updating generator metadata/template hashes and applying minor formatting/output differences. - Minor reordering of some
dependsOnentries ininfra/main.json(no functional change expected).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/main.json | Regenerated ARM template (updated Bicep generator metadata/hashes; minor output formatting and dependsOn ordering adjustments). |
| infra/main.bicep | Updated role assignment comment to reflect “Foundry User” naming for the existing role definition ID. |
| infra/main_custom.bicep | Kept in sync with main.bicep for the same role naming update. |
| docs/LocalDevelopmentSetup.md | Updated example role assignment command to use the “Foundry User” role name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
infra/main.jsontemplate, primarily reflecting updates from a newer Bicep compiler version and minor dependency ordering adjustments.Role assignment and documentation updates:
infra/main.bicep,infra/main_custom.bicep, anddocs/LocalDevelopmentSetup.mdto reference "Foundry User" instead of "Azure AI User" for role assignments. [1] [2] [3]Infrastructure template and dependency updates:
infra/main.jsonwith Bicep version0.43.8.12551(was0.42.1.51946), resulting in newtemplateHashvalues and minor metadata/description formatting changes. [1] [2] [3] [4] [5] [6] [7] [8] [9]infra/main.jsonto group related DNS zones together more logically. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information